linux-kernel - Re: [PATCH] usb: dwc3: ep0: Don't reset resource alloc flag (including ep0)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240815012634.c5dw7neyfyly2nuo@synopsys.com>
Date: Thu, 15 Aug 2024 01:26:38 +0000
From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
CC: Michael Grzeschik <m.grzeschik@...gutronix.de>,
        Sergey Shtylyov
	<s.shtylyov@....ru>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc3: ep0: Don't reset resource alloc flag
 (including ep0)

On Thu, Aug 15, 2024, Thinh Nguyen wrote:
> On Wed, Aug 14, 2024, Thinh Nguyen wrote:
> > Hi Michael,
> > 
> > On Wed, Aug 14, 2024, Sergey Shtylyov wrote:
> > > On 8/14/24 11:42 PM, Sergey Shtylyov wrote:
> > > [...]
> > > 
> > > >> The DWC3_EP_RESOURCE_ALLOCATED flag ensures that the resource of an
> > > >> endpoint is only assigned once. Unless the endpoint is reset, don't
> > > >> clear this flag. Otherwise we may set endpoint resource again, which
> > > >> prevents the driver from initiate transfer after handling a STALL or
> > > >> endpoint halt to the control endpoint.
> > > >>
> > > >> Commit f2e0eee47038 (usb: dwc3: ep0: Don't reset resource alloc flag)
> > > > 
> > > >    You forgot the double quotes around the summary, the same as you
> > > > do in the Fixes tag.
> > > > 
> > > >> was fixing the initial issue, but did this only for physical ep1. Since
> > > >> the function dwc3_ep0_stall_and_restart is resetting the flags for both
> > > >> physical endpoints, this also has to be done for ep0.
> > > >>
> > > >> Cc: stable@...r.kernel.org
> > > >> Fixes: b311048c174d ("usb: dwc3: gadget: Rewrite endpoint allocation flow")
> > > >> Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>
> > 
> > Thanks for the catch!
> > 
> > If you send v2 for the double quote fix in the commit message, you can
> > include this:
> > 
> > Acked-by: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
> > 
> 
> Actually, please ignore the Ack. Please do this instead:
> 
> diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
> index d96ffbe52039..9b069c4663a1 100644
> --- a/drivers/usb/dwc3/ep0.c
> +++ b/drivers/usb/dwc3/ep0.c
> @@ -232,7 +232,7 @@ void dwc3_ep0_stall_and_restart(struct dwc3 *dwc)
>         /* stall is always issued on EP0 */
>         dep = dwc->eps[0];
>         __dwc3_gadget_ep_set_halt(dep, 1, false);
> -       dep->flags = DWC3_EP_ENABLED;
> +       dep->flags &= ~DWC3_EP_STALL;
>         dwc->delayed_status = false;
> 
>         if (!list_empty(&dep->pending_list)) {
> 
> 
> We don't want to clear other flags such as wedge flag.
> 

Ugh... sorry for the spam... ignore the above. I forgot that we can't
wedge control ep. What you have is fine.

Thanks,
Thinh