linux-kernel - Re: [PATCH 6.10 000/263] 6.10.5-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b27c5434-f1b1-4697-985b-91bb3e9a22df@roeck-us.net>
Date: Fri, 16 Aug 2024 07:43:31 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: stable@...r.kernel.org, patches@...ts.linux.dev,
 linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
 akpm@...ux-foundation.org, shuah@...nel.org, patches@...nelci.org,
 lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
 f.fainelli@...il.com, sudipm.mukherjee@...il.com, srw@...dewatkins.net,
 rwarsow@....de, conor@...nel.org, allen.lkml@...il.com, broonie@...nel.org
Subject: Re: [PATCH 6.10 000/263] 6.10.5-rc1 review

On 8/16/24 01:38, Greg Kroah-Hartman wrote:
> On Thu, Aug 15, 2024 at 07:21:00AM -0700, Guenter Roeck wrote:
>> On 8/12/24 09:00, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 6.10.5 release.
>>> There are 263 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Wed, 14 Aug 2024 16:00:26 +0000.
>>> Anything received after that time might be too late.
>>>
>>
>> I see various allmodconfig build failures on v6.10.5.
>>
>> Example from arm:
>>
>> Building arm:allmodconfig ... failed
>> --------------
>> Error log:
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:1581:13: error: 'is_dsc_common_config_possible' defined but not used [-Werror=unused-function]
>>   1581 | static bool is_dsc_common_config_possible(struct dc_stream_state *stream,
>>        |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:1569:21: error: 'kbps_from_pbn' defined but not used [-Werror=unused-function]
>>   1569 | static unsigned int kbps_from_pbn(unsigned int pbn)
>>
>> The functions are built and used conditionally in mainline, behind CONFIG_DRM_AMD_DC_FP.
>> The conditional is missing in v6.10.5 (and v6.10.6-rc1).
> 
> Odd that other allmodconfig builds passed :(
> 

Yes, that is odd. Maybe they all build with clang nowadays ?

> I'll dig up where that conditional showed up, thanks for letting us
> know....
> 
> Ah, looks like it showed up in 00c391102abc ("drm/amd/display: Add misc
> DC changes for DCN401"), gotta love "fix a bunch of things" type of
> commits...
> 

I found that as well, but as you noticed it is a mess.

Your partially applied patch introduced other problems -
please see my other e-mail.

Guenter