linux-kernel - Re: (subset) [PATCH] leds: pca995x: Fix device child node usage in pca995x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172382409029.3366296.12169044923782597357.b4-ty@kernel.org>
Date: Fri, 16 Aug 2024 17:01:30 +0100
From: Lee Jones <lee@...nel.org>
To: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>, 
 Isai Gaspar <isaiezequiel.gaspar@....com>, Marek Vasut <marex@...x.de>, 
 Jonathan Cameron <jic23@...nel.org>, 
 Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: (subset) [PATCH] leds: pca995x: Fix device child node usage in
 pca995x_probe()

On Wed, 07 Aug 2024 15:37:03 +0200, Javier Carrasco wrote:
> The current implementation accesses the `child` fwnode handle outside of
> device_for_each_child_node() without incrementing its refcount.
> 
> Add the missing call to `fwnode_handle_get(child)`.
> 
> The cleanup process where `child` is accessed is not right either
> because a single call to `fwnode_handle_put()` is carried out in case of
> an error, ignoring unasigned nodes at the point when the error happens.
> 
> [...]

Applied, thanks!

[1/1] leds: pca995x: Fix device child node usage in pca995x_probe()
      commit: 82c5ada1f9d05902a4ccb926c7ce34e2fe699283

--
Lee Jones [李琼斯]