linux-kernel - Re: [PATCH v3 1/1] dt-bindings: input: touchscreen: convert ads7846.txt to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d42f0f37-9c17-4daa-a807-23e8b5c5668b@denx.de>
Date: Fri, 16 Aug 2024 18:36:03 +0200
From: Marek Vasut <marex@...x.de>
To: Frank Li <Frank.Li@....com>, Dmitry Torokhov <dmitry.torokhov@...il.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Linus Walleij
 <linus.walleij@...aro.org>, Mark Hasemeyer <markhas@...omium.org>,
 Alexander Stein <alexander.stein@...tq-group.com>,
 "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..."
 <linux-input@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Cc: imx@...ts.linux.dev
Subject: Re: [PATCH v3 1/1] dt-bindings: input: touchscreen: convert
 ads7846.txt to yaml

On 8/16/24 6:12 PM, Frank Li wrote:

[...]

> +  ti,debounce-max:
> +    deprecated: true
> +    $ref: /schemas/types.yaml#/definitions/uint16
> +    description: Max number of additional readings per sample.
> +
> +  ti,debounce-rep:
> +    $ref: /schemas/types.yaml#/definitions/uint16
> +    description:
> +      Additional consecutive good readings required after the first two.

Should the description: and the description text be on the same line ? 
Or separate by newline ? Or should it use description: | and then a 
newline ?

It would be good to be consistent about this.

> +  ti,debounce-tol:
> +    $ref: /schemas/types.yaml#/definitions/uint16
> +    description: Tolerance used for filtering.
> +
> +  ti,hsync-gpios:
> +    description:
> +      GPIO line to poll for hsync

Please make sure each sentence ends with a fullstop '.' .

Thanks !