linux-kernel - Re: [PATCH] workqueue: fix null-ptr-deref on __alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240816025223.GE12106@google.com>
Date: Fri, 16 Aug 2024 11:52:23 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Matthew Brost <matthew.brost@...el.com>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>,
	Tejun Heo <tj@...nel.org>, Lai Jiangshan <jiangshanlai@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] workqueue: fix null-ptr-deref on __alloc_workqueue()
 error

On (24/08/16 02:45), Matthew Brost wrote:
[..]
> > Oh, I haven't checked the workqueue header.  Yes, you are right.
> > A macro should work.
> > 
> 
> To be clear we your change to __alloc_workqueue in workqueue.c AND my
> change to a macro in workqueue.h.

Oh, yes, correct, that's what I meant too - we need both.

// Plus a null-ptr-deref fix in __alloc_workqueue() error path.