linux-kernel - Re: [PATCH 4/4] MAINTAINERS: drop NXP LAYERSCAPE GEN4 CONTROLLER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zr+H3gHZ/B7zTKBW@lizhi-Precision-Tower-5810>
Date: Fri, 16 Aug 2024 13:09:50 -0400
From: Frank Li <Frank.li@....com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kw@...ux.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Zhiqiang.Hou@....com,
	linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH 4/4] MAINTAINERS: drop NXP LAYERSCAPE GEN4 CONTROLLER

On Fri, Aug 16, 2024 at 11:12:31AM +0530, Manivannan Sadhasivam wrote:
> On Thu, Aug 15, 2024 at 03:15:52PM -0600, Rob Herring wrote:
> > On Thu, Aug 15, 2024 at 9:53 AM Manivannan Sadhasivam
> > <manivannan.sadhasivam@...aro.org> wrote:
> > >
> > > On Thu, Aug 08, 2024 at 12:02:17PM -0400, Frank Li wrote:
> > > > LX2160 Rev1 use mobivel PCIe controller, but Rev2 switch to designware
> > > > PCIe controller. Rev2 is mass production chip. Rev1 will not be maintained
> > > > so drop maintainer information for that.
> > > >
> > >
> > > Instead of suddenly removing the code and breaking users, you can just mark the
> > > driver as 'Obsolete' in MAINTAINERS. Then after some point of time, we could
> > > hopefully remove.
> >
> > Is anyone really going to pay attention to that? It doesn't sound like
> > there's anyone to really care, and it is the company that made the h/w
> > asking to remove it. The only thing people use pre-production h/w for
> > once there's production h/w is as a dust collector.
> >
> > If anyone complains, it's simple enough to revert these patches.
> >
>
> My comment was based on the fact that Bjorn was not comfortable in removing the
> driver [1] unless no Rev1 boards are not in use and Frank said that he was not
> sure about that [2].
>
> But I think if Frank can atleast guarantee that the chip never made into mass
> production or shared with customers, then we can remove the driver IMO. But that
> is up to the discretion of Bjorn.
>

I think Bjoin's request is impossible task. Generally chip company send
out some evaluted sample to parter, which use these sample to built up
some small quantity production. Chip company have not responsibility to
call back this samples. There are always some reasons to drop mobivel and
switch designware, it may be caused by some IP issues which can't match
mass production's requirememnt. Such informaiton already removed from
nxp.com. Only Rev2 left.

Leave such dead code in pci tree actually no harm for me, and clean up need
extra efforts.

I send out v2, which don't build gen4 driver default. It may a feasibility
way to do clean up. If no one complain for a while, it should be dead.

https://lore.kernel.org/imx/20240815182420.58821-1-Frank.Li@nxp.com/T/#u

Frank

> - Mani
>
> [1] https://lore.kernel.org/linux-pci/20240808172644.GA151261@bhelgaas/
> [2] https://lore.kernel.org/linux-pci/ZrUJngABI8v3pN6o@lizhi-Precision-Tower-5810/
>
> - Mani
>
> --
> மணிவண்ணன் சதாசிவம்