linux-kernel - Re: [PATCH] cxgb4: add forgotten u64 ivlan cast before shift

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240816172012.GF632411@kernel.org>
Date: Fri, 16 Aug 2024 18:20:12 +0100
From: Simon Horman <horms@...nel.org>
To: Nikolay Kuratov <kniv@...dex-team.ru>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	stable@...r.kernel.org, lvc-project@...uxtesting.org,
	Kumar Sanghvi <kumaras@...lsio.com>,
	Potnuri Bharat Teja <bharat@...lsio.com>,
	Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>,
	Ganesh Goudar <ganeshgr@...lsio.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] cxgb4: add forgotten u64 ivlan cast before shift

On Fri, Aug 16, 2024 at 11:22:39AM +0300, Nikolay Kuratov wrote:
> It is done everywhere in cxgb4 code, e.g. in is_filter_exact_match()
> There is no reason it should not be done here
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE
> 
> Signed-off-by: Nikolay Kuratov <kniv@...dex-team.ru>
> Cc: stable@...r.kernel.org
> Fixes: 12b276fbf6e0 ("cxgb4: add support to create hash filters")
> ---
>  drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> index 786ceae34488..e417ff0ea06c 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> @@ -1244,7 +1244,7 @@ static u64 hash_filter_ntuple(struct ch_filter_specification *fs,
>  	 * in the Compressed Filter Tuple.
>  	 */
>  	if (tp->vlan_shift >= 0 && fs->mask.ivlan)
> -		ntuple |= (FT_VLAN_VLD_F | fs->val.ivlan) << tp->vlan_shift;
> +		ntuple |= (u64)(FT_VLAN_VLD_F | fs->val.ivlan) << tp->vlan_shift;

LGTM, but please line wrap this so that it doesn't extend
beyond 80 columns wide (as is the case elsewhere in this function).

>  
>  	if (tp->port_shift >= 0 && fs->mask.iport)
>  		ntuple |= (u64)fs->val.iport << tp->port_shift;

-- 
pw-bot: cr