[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240816111810.64355472@kernel.org>
Date: Fri, 16 Aug 2024 11:18:10 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Divya Koppera <divya.koppera@...rochip.com>
Cc: <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
<davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<arun.ramadoss@...rochip.com>, <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next v2 1/2] net: phy: Add phy library support to
check supported list when autoneg is enabled
On Tue, 13 Aug 2024 23:45:14 +0530 Divya Koppera wrote:
> - if (autoneg == AUTONEG_ENABLE && linkmode_empty(advertising))
> + if (autoneg == AUTONEG_ENABLE &&
> + (linkmode_empty(advertising) ||
> + !(linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,
> + phydev->supported))))
nti: no need to wrap the linkmode_test_bit() in brackets:
!linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,
phydev->supported)))
otherwise LGTM.
Please try to put links to previous versions into the cover letter.
--
pw-bot: cr
Powered by blists - more mailing lists