linux-kernel - Re: [PATCH v12 00/10] enable bs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2924797.1723836663@warthog.procyon.org.uk>
Date: Fri, 16 Aug 2024 20:31:03 +0100
From: David Howells <dhowells@...hat.com>
To: "Pankaj Raghav (Samsung)" <kernel@...kajraghav.com>
Cc: dhowells@...hat.com, brauner@...nel.org, akpm@...ux-foundation.org,
    chandan.babu@...cle.com, linux-fsdevel@...r.kernel.org,
    djwong@...nel.org, hare@...e.de, gost.dev@...sung.com,
    linux-xfs@...r.kernel.org, hch@....de, david@...morbit.com,
    Zi Yan <ziy@...dia.com>, yang@...amperecomputing.com,
    linux-kernel@...r.kernel.org, linux-mm@...ck.org,
    willy@...radead.org, john.g.garry@...cle.com,
    cl@...amperecomputing.com, p.raghav@...sung.com, mcgrof@...nel.org,
    ryan.roberts@....com
Subject: Re: [PATCH v12 00/10] enable bs > ps in XFS

Hi Pankaj,

I applied the first five patches and set minimum folio size for afs files to
8K (see attached patch) and ran some tests.

With simple tests, I can see in the trace log that it is definitely creating
8K folios where it would previously create 4K folios.

However, with 'xfstests -g quick', generic/075 generic/112 generic/393 fail
where they didn't previously.  I won't be able to look into this more till
Monday.

If you want to try using afs for yourself, install the kafs-client package
(available on Fedora and Debian), do 'systemctl start afs.mount' and then you
can, say, do:

	ls /afs/openafs.org/www/docs.openafs.org/

and browse the publicly accessible files under there.

David
---
commit d676df787baee3b710b9f0d284b21518473feb3c
Author: David Howells <dhowells@...hat.com>
Date:   Fri Aug 16 19:54:25 2024 +0100

    afs: [DEBUGGING] Set min folio order

diff --git a/fs/afs/inode.c b/fs/afs/inode.c
index 3acf5e050072..c3842cba92e7 100644
--- a/fs/afs/inode.c
+++ b/fs/afs/inode.c
@@ -104,6 +104,7 @@ static int afs_inode_init_from_status(struct afs_operation *op,
 		inode->i_fop	= &afs_file_operations;
 		inode->i_mapping->a_ops	= &afs_file_aops;
 		mapping_set_large_folios(inode->i_mapping);
+		mapping_set_folio_min_order(inode->i_mapping, 1);
 		break;
 	case AFS_FTYPE_DIR:
 		inode->i_mode	= S_IFDIR |  (status->mode & S_IALLUGO);