linux-kernel - Re: [PATCH] kunit/overflow: Fix UB in overflow_allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <32F8F341-56C1-4E2A-9227-9909980A153C@kernel.org>
Date: Thu, 15 Aug 2024 20:36:49 -0700
From: Kees Cook <kees@...nel.org>
To: Andrew Morton <akpm@...ux-foundation.org>,
 Ivan Orlov <ivan.orlov0322@...il.com>
CC: davidgow@...gle.com, kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org,
 erhard_f@...lbox.org
Subject: Re: [PATCH] kunit/overflow: Fix UB in overflow_allocation_test



On August 15, 2024 4:01:48 PM PDT, Andrew Morton <akpm@...ux-foundation.org> wrote:
>On Thu, 15 Aug 2024 01:04:31 +0100 Ivan Orlov <ivan.orlov0322@...il.com> wrote:
>
>> The 'device_name' array doesn't exist out of the
>> 'overflow_allocation_test' function scope. However, it is being used as
>> a driver name when calling 'kunit_driver_create' from
>> 'kunit_device_register'. It produces the kernel panic with KASAN
>> enabled.
>> 
>> Since this variable is used in one place only, remove it and pass the
>> device name into kunit_device_register directly as an ascii string.
>
>Fixes: ca90800a91ba ("test_overflow: Add memory allocation overflow tests")
>Cc: <stable@...r.kernel.org>
>
>yes?
>
>
>I'll grab it now, but perhaps Kees will handle this.

I already grabbed it:
https://lore.kernel.org/lkml/172373928009.559695.8528767427266408069.b4-ty@kernel.org/

But I'll update the tags. Thanks!

-- 
Kees Cook