linux-kernel - Re: [PATCH v9 1/6] rust: kernel: add `drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72mr53kE2s3so-xK5BpiqbuH+cStZ6qrN9X6TROBR6WAHg@mail.gmail.com>
Date: Fri, 16 Aug 2024 23:11:22 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Matt Gilbride <mattgilbride@...gle.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Wedson Almeida Filho <wedsonaf@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...sung.com>, 
	Alice Ryhl <aliceryhl@...gle.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Arve Hjønnevåg <arve@...roid.com>, 
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>, 
	Joel Fernandes <joel@...lfernandes.org>, Carlos Llamas <cmllamas@...gle.com>, 
	Suren Baghdasaryan <surenb@...gle.com>, Christian Brauner <brauner@...nel.org>, Rob Landley <rob@...dley.net>, 
	Davidlohr Bueso <dave@...olabs.net>, Michel Lespinasse <michel@...pinasse.org>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 1/6] rust: kernel: add `drop_contents` to `BoxExt`

On Fri, Aug 16, 2024 at 10:48 PM Matt Gilbride <mattgilbride@...gle.com> wrote:
>
> From: Benno Lossin <benno.lossin@...ton.me>
>
> Sometimes (see [1]) it is necessary to drop the value inside of a
> `Box<T>`, but retain the allocation. For example to reuse the allocation
> in the future.
> Introduce a new function `drop_contents` that turns a `Box<T>` into
> `Box<MaybeUninit<T>>` by dropping the value.
>
> Signed-off-by: Benno Lossin <benno.lossin@...ton.me>
> Link: https://lore.kernel.org/rust-for-linux/20240418-b4-rbtree-v3-5-323e134390ce@google.com/ [1]
> Reviewed-by: Boqun Feng <boqun.feng@...il.com>
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>

When sending a patch from someone else, then your own Signed-off-by is
still needed at the bottom.

By the way, since you are editing `helpers.c` later in the series, if
you don't mind rebasing on top of the helpers split [1], that would be
great (I am putting that one into rust-next very soon, in case it
helps):

    https://lore.kernel.org/rust-for-linux/20240815103016.2771842-1-nmi@metaspace.dk/

Thanks!

Cheers,
Miguel