linux-kernel - Re: [PATCH] SUNRPC: Fix -Wformat-truncation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a957b7bb-e5c2-480f-8f5c-2fa40637d8ba@lunn.ch>
Date: Sat, 17 Aug 2024 00:01:03 +0200
From: Andrew Lunn <andrew@...n.ch>
To: kunwu.chan@...ux.dev
Cc: trondmy@...nel.org, anna@...nel.org, chuck.lever@...cle.com,
	jlayton@...nel.org, neilb@...e.de, kolga@...app.com,
	Dai.Ngo@...cle.com, tom@...pey.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	linux-nfs@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Kunwu Chan <chentao@...inos.cn>
Subject: Re: [PATCH] SUNRPC: Fix -Wformat-truncation warning

On Wed, Aug 14, 2024 at 05:38:53PM +0800, kunwu.chan@...ux.dev wrote:
> From: Kunwu Chan <chentao@...inos.cn>
> 
> Increase size of the servername array to avoid truncated output warning.
> 
> net/sunrpc/clnt.c:582:75: error：‘%s’ directive output may be truncated
> writing up to 107 bytes into a region of size 48
> [-Werror=format-truncation=]
>   582 |                   snprintf(servername, sizeof(servername), "%s",
>       |                                                             ^~
> 
> net/sunrpc/clnt.c:582:33: note:‘snprintf’ output
> between 1 and 108 bytes into a destination of size 48
>   582 |                     snprintf(servername, sizeof(servername), "%s",
>       |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   583 |                                          sun->sun_path);

I think this has come up before, but i could be mis-remembering.
Please could you do a search for the discussion. The fact it is not
solved suggests to me it is not so simple to fix. Maybe there is some
protocol implications here.

       Andrew