linux-kernel - Re: [PATCH] mm/migrate: fix deadlock in migrate_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240815220224.d7970835d5c12b4833bd04dc@linux-foundation.org>
Date: Thu, 15 Aug 2024 22:02:24 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Gao Xiang <hsiangkao@...ux.alibaba.com>
Cc: "Huang, Ying" <ying.huang@...el.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/migrate: fix deadlock in migrate_pages_batch() on
 large folios

On Mon, 29 Jul 2024 09:58:02 +0800 Gao Xiang <hsiangkao@...ux.alibaba.com> wrote:

> > For the fix, I think that we should still respect migrate_mode because
> > users may prefer migration success over blocking.
> > 
> > @@ -1492,11 +1492,17 @@ static int unmap_and_move_huge_page(new_folio_t get_new_folio,
> >   	return rc;
> >   }
> >   
> > -static inline int try_split_folio(struct folio *folio, struct list_head *split_folios)
> > +static inline int try_split_folio(struct folio *folio, struct list_head *split_folios,
> > +				  enum migrate_mode mode)
> >   {
> >   	int rc;
> >   
> > -	folio_lock(folio);
> > +	if (mode == MIGRATE_ASYNC) {
> > +		if (!folio_trylock(folio))
> > +			return -EAGAIN;
> > +	} else {
> > +		folio_lock(folio);
> > +	}
> >   	rc = split_folio_to_list(folio, split_folios);
> >   	folio_unlock(folio);
> >   	if (!rc)
> 
> Okay, yeah it looks better since it seems I missed the fallback
> part in migrate_pages_sync().
> 
> Let me send the next version to follow your advice, thanks.

The author seems to have disappeared.  Should we merge this as-is or
does someone want to take a look at developing a v2?

Thanks.