[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <aa3a1835-19e0-43a5-b6a4-4a7e531f3b2e@kernel.org>
Date: Fri, 16 Aug 2024 07:08:02 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kevin Chen <kevin_chen@...eedtech.com>, "robh@...nel.org"
<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>, "joel@....id.au"
<joel@....id.au>, "andrew@...econstruct.com.au"
<andrew@...econstruct.com.au>, "lee@...nel.org" <lee@...nel.org>,
"catalin.marinas@....com" <catalin.marinas@....com>,
"will@...nel.org" <will@...nel.org>, "arnd@...db.de" <arnd@...db.de>,
"olof@...om.net" <olof@...om.net>, "soc@...nel.org" <soc@...nel.org>,
"mturquette@...libre.com" <mturquette@...libre.com>,
"sboyd@...nel.org" <sboyd@...nel.org>,
"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
"quic_bjorande@...cinc.com" <quic_bjorande@...cinc.com>,
"geert+renesas@...der.be" <geert+renesas@...der.be>,
"dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>,
"shawnguo@...nel.org" <shawnguo@...nel.org>,
"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
"m.szyprowski@...sung.com" <m.szyprowski@...sung.com>,
"nfraprado@...labora.com" <nfraprado@...labora.com>,
"u-kumar1@...com" <u-kumar1@...com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
BMC-SW <BMC-SW@...eedtech.com>
Subject: Re: 回覆: [PATCH v1 08/10] arm64: dts: aspeed: Add initial AST27XX device tree
On 15/08/2024 07:50, Kevin Chen wrote:
>>> diff --git a/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi b/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
>>> new file mode 100644
>>> index 000000000000..858ab95251e4
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
>>> @@ -0,0 +1,217 @@
>>> +// SPDX-License-Identifier: GPL-2.0-or-later
>>> +#include <dt-bindings/clock/aspeed,ast2700-clk.h>
>>> +#include <dt-bindings/reset/aspeed,ast2700-reset.h>
>>> +#include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +#include <dt-bindings/interrupt-controller/aspeed-scu-ic.h>
>>> +
>>> +/ {
>>> + model = "Aspeed BMC";
>>
>> Model of what? No, drop.
> Can I change to "model = "AST2700 EVB""
Model of what? No, it does not make sense here.
..
>>> +
>>> + uart12: serial@...33b00 {
>>> + compatible = "ns16550a";
>>> + reg = <0x0 0x14c33b00 0x0 0x100>;
>>> + reg-shift = <2>;
>>> + reg-io-width = <4>;
>>> + clocks = <&syscon1 SCU1_CLK_GATE_UART12CLK>;
>>> + no-loopback-test;
>>> + pinctrl-names = "default";
>>
>> What is this?
> BMC uart using in uart12 in soc1.
No, that line. pinctrl-names do not make sense here without values.
>
>>
>>> + };
>>> + };
>>> +};
>>> +
>
> --
> Best Regards,
> Kevin. Chen
> ________________________________
> 寄件者: Krzysztof Kozlowski <krzk@...nel.org>
> 寄件日期: 2024年7月26日 下午 07:19
> 收件者: Kevin Chen <kevin_chen@...eedtech.com>; robh@...nel.org <robh@...nel.org>; krzk+dt@...nel.org <krzk+dt@...nel.org>; conor+dt@...nel.org <conor+dt@...nel.org>; joel@....id.au <joel@....id.au>; andrew@...econstruct.com.au <andrew@...econstruct.com.au>; lee@...nel.org <lee@...nel.org>; catalin.marinas@....com <catalin.marinas@....com>; will@...nel.org <will@...nel.org>; arnd@...db.de <arnd@...db.de>; olof@...om.net <olof@...om.net>; soc@...nel.org <soc@...nel.org>; mturquette@...libre.com <mturquette@...libre.com>; sboyd@...nel.org <sboyd@...nel.org>; p.zabel@...gutronix.de <p.zabel@...gutronix.de>; quic_bjorande@...cinc.com <quic_bjorande@...cinc.com>; geert+renesas@...der.be <geert+renesas@...der.be>; dmitry.baryshkov@...aro.org <dmitry.baryshkov@...aro.org>; shawnguo@...nel.org <shawnguo@...nel.org>; neil.armstrong@...aro.org <neil.armstrong@...aro.org>; m.szyprowski@...sung.com <m.szyprowski@...sung.com>; nfraprado@...labora.com <nfraprado@...labora.com>; u-kumar1@...com <u-kumar1@...com>; devicetree@...r.kernel.org <devicetree@...r.kernel.org>; linux-arm-kernel@...ts.infradead.org <linux-arm-kernel@...ts.infradead.org>; linux-aspeed@...ts.ozlabs.org <linux-aspeed@...ts.ozlabs.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; linux-clk@...r.kernel.org <linux-clk@...r.kernel.org>
> 主旨: Re: [PATCH v1 08/10] arm64: dts: aspeed: Add initial AST27XX device tree
>
Why do you quote my email twice?
...
>> + uart12: serial@...33b00 {
>> + compatible = "ns16550a";
>> + reg = <0x0 0x14c33b00 0x0 0x100>;
>> + reg-shift = <2>;
>> + reg-io-width = <4>;
>> + clocks = <&syscon1 SCU1_CLK_GATE_UART12CLK>;
>> + no-loopback-test;
>> + pinctrl-names = "default";
>
> What is this?
>
>> + };
>> + };
>> +};
>> +
>
> Best regards,
> Krzysztof
>
> ************* Email Confidentiality Notice ********************
> 免責聲明:
> 本信件(或其附件)可能包含機密資訊,並受法律保護。如 台端非指定之收件者,請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作!
>
> DISCLAIMER:
> This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
Maybe I am the intended recipient of your message, maybe not. I don't
want to have any legal questions regarding upstream, public
collaboration, thus probably I should just remove your messages.
Please talk with your IT that such disclaimers in open-source are not
desired (and maybe even harmful).
If you do not understand why, please also see:
https://www.youtube.com/live/fMeH7wqOwXA?si=GY7igfbda6vnjXlJ&t=835
If you need to go around company SMTP server, then consider using b4
web-relay: https://b4.docs.kernel.org/en/latest/contributor/send.html
Please be informed that by responding to this email you agree that all
communications from you and/or your company is made public. In other
words, all messages originating from you and/or your company will be
made public.
Best regards,
Krzysztof
Powered by blists - more mailing lists