linux-kernel - Re: [PATCH v3 4/8] clk: qcom: Add support for Camera Clock Controller on SA8775P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a619c8fa-e107-435d-a09f-487c31e68b86@quicinc.com>
Date: Fri, 16 Aug 2024 10:43:41 +0530
From: Taniya Das <quic_tdas@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        "Stephen
 Boyd" <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bartosz Golaszewski
	<bartosz.golaszewski@...aro.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_imrashai@...cinc.com>, <quic_jkona@...cinc.com>
Subject: Re: [PATCH v3 4/8] clk: qcom: Add support for Camera Clock Controller
 on SA8775P



On 7/16/2024 5:37 PM, Konrad Dybcio wrote:
> On 15.07.2024 10:23 AM, Taniya Das wrote:
>> Add support for Camera Clock Controller on SA8755P platform.
>>
>> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
>> ---
> 
> [...]
> 
>> +
>> +static struct gdsc cam_cc_titan_top_gdsc = {
>> +	.gdscr = 0x131bc,
>> +	.en_rest_wait_val = 0x2,
>> +	.en_few_wait_val = 0x2,
>> +	.clk_dis_wait_val = 0xf,
> 
> Shouldn't this also have a .cxcs relating to GCC_CAMERA_AHB_CLK?
> 
> Konrad

Not really required, this external GCC clock would be kept always 
enabled from GCC driver.

-- 
Thanks & Regards,
Taniya Das.