[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d72c9acd-dbcd-4c78-94d2-c0a0e854c5fa@linaro.org>
Date: Fri, 16 Aug 2024 07:30:59 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Michal Simek <michal.simek@....com>,
Grygorii Strashko <grygorii.strashko@...com>, Vignesh R <vigneshr@...com>,
Felipe Balbi <felipe.balbi@...ux.intel.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
Piyush Mehta <piyush.mehta@....com>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH 2/2] usb: dwc3: xilinx: add missing depopulate in probe
error path
On 15/08/2024 01:31, Thinh Nguyen wrote:
> On Wed, Aug 14, 2024, Krzysztof Kozlowski wrote:
>> Depopulate device in probe error paths to fix leak of children
>> resources.
>>
>> Fixes: 53b5ff83d893 ("usb: dwc3: xilinx: improve error handling for PM APIs")
>> Cc: <stable@...r.kernel.org>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>> drivers/usb/dwc3/dwc3-xilinx.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c
>> index bb4d894c16e9..b7613a106da6 100644
>> --- a/drivers/usb/dwc3/dwc3-xilinx.c
>> +++ b/drivers/usb/dwc3/dwc3-xilinx.c
>> @@ -330,6 +330,7 @@ static int dwc3_xlnx_probe(struct platform_device *pdev)
>> return pm_runtime_resume_and_get(dev);
>
> If pm_runtime_resume_and_get() fails, then probe will fail. We should
> probably cleanup in that case too.
I will take a look.
Best regards,
Krzysztof
Powered by blists - more mailing lists