linux-kernel - Re: [PATCH 4/6] um: Remove unused mm_fd field from mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3be8448cfb2aeb39e0e73856a701101dc8a0f04f.camel@sipsolutions.net>
Date: Fri, 16 Aug 2024 07:59:35 +0200
From: Benjamin Berg <benjamin@...solutions.net>
To: Tiwei Bie <tiwei.btw@...group.com>, richard@....at, 
	anton.ivanov@...bridgegreys.com, johannes@...solutions.net
Cc: linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] um: Remove unused mm_fd field from mm_id

Hi Tiwei,

On Fri, 2024-08-16 at 09:54 +0800, Tiwei Bie wrote:
> It's no longer used since the removal of the SKAS3/4 support.
> 
> Signed-off-by: Tiwei Bie <tiwei.btw@...group.com>
> ---
>  arch/um/include/shared/skas/mm_id.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/um/include/shared/skas/mm_id.h
> b/arch/um/include/shared/skas/mm_id.h
> index 1e76ba40feba..b3571a8afec9 100644
> --- a/arch/um/include/shared/skas/mm_id.h
> +++ b/arch/um/include/shared/skas/mm_id.h
> @@ -8,7 +8,6 @@
>  
>  struct mm_id {
>  	union {
> -		int mm_fd;
>  		int pid;
>  	} u;
>  	unsigned long stack;

Maybe we should also remove the union here while at it? It is pretty
pointless after all.

Benjamin