linux-kernel - Re: [PATCH] Input: evdev - limit amount of data for writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zr7u78IvuiwbmxYZ@google.com>
Date: Thu, 15 Aug 2024 23:17:19 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Peter Hutterer <peter.hutterer@...-t.net>
Cc: linux-input@...r.kernel.org, Jeff LaBundy <jeff@...undy.com>,
	Benjamin Tissoires <bentiss@...nel.org>,
	linux-kernel@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH] Input: evdev - limit amount of data for writes

On Fri, Aug 16, 2024 at 10:18:05AM +1000, Peter Hutterer wrote:
> On Thu, Aug 15, 2024 at 11:41:53AM -0700, Dmitry Torokhov wrote:
> > Limit amount of data that can be written into an evdev instance at
> > a given time to 4096 bytes (170 input events) to avoid holding
> > evdev->mutex for too long and starving other users.
> > 
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> 
> I'd expect anything coming near 170 input events is going to trigger
> SYN_DROPPED anyway, so:

This actually going the other direction (userspace -> kernel) so there
will be no SYN_DROPPED, at least on the way in.

> 
> Reviewed-by: Peter Hutterer <peter.hutterer@...-t.net>

Thanks for the review!

-- 
Dmitry