[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e640cbc4-6870-4607-a91e-0af41dd76df9@kernel.org>
Date: Fri, 16 Aug 2024 08:52:04 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Heiko Stübner <heiko@...ech.de>,
linux-kernel@...r.kernel.org, Detlev Casanova <detlev.casanova@...labora.com>
Cc: Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Jaehoon Chung <jh80.chung@...sung.com>,
linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
kernel@...labora.com
Subject: Re: [PATCH v3 1/3] dt-bindings: mmc: Add support for rk3576 dw-mshc
On 15/08/2024 15:49, Heiko Stübner wrote:
> Am Donnerstag, 15. August 2024, 00:34:00 CEST schrieb Detlev Casanova:
>> Add the compatible string for rockchip,rk3576-dw-mshc and add support
>> for the rockchip,v2-tuning flag, a new feature of this core.
>>
>> Signed-off-by: Detlev Casanova <detlev.casanova@...labora.com>
>> ---
>> Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
>> index 211cd0b0bc5f3..0543cdb51c657 100644
>> --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
>> @@ -39,6 +39,7 @@ properties:
>> - rockchip,rk3368-dw-mshc
>> - rockchip,rk3399-dw-mshc
>> - rockchip,rk3568-dw-mshc
>> + - rockchip,rk3576-dw-mshc
>> - rockchip,rk3588-dw-mshc
>> - rockchip,rv1108-dw-mshc
>> - rockchip,rv1126-dw-mshc
>
> this would mark the rk3576-dw-mshc as being the "same" as the
Not the same, but compatible.
> core rk3288 variant. rk3288 was the first controller introducing the
> clock tuning for higher speeds. with the clocks being part of the CRU.
>
> As we can see in later patches, this rk3576 though changes that
> setup with moving the tunable clock configurations into the controller
> itself.
>
> So please don't claim to be compatible to the 3288, but instead start
> a new block for this new set of controllers:
The question is can new device work with old compatible (without new
features)?
Best regards,
Krzysztof
Powered by blists - more mailing lists