linux-kernel - Re: [PATCH] HID: corsair-void: Add Corsair Void headset family driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALTg27k7jMNReN-XxGC+XW6Kw_+N=HB+oKDHX1VAgTuaAoyDbQ@mail.gmail.com>
Date: Fri, 16 Aug 2024 01:57:30 +0100
From: Stuart <stuart.a.hayhurst@...il.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-input@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, 
	Benjamin Tissoires <bentiss@...nel.org>, Jiri Kosina <jikos@...nel.org>
Subject: Re: [PATCH] HID: corsair-void: Add Corsair Void headset family driver

> Such information should not belong to the change description.
> It may be specified behind the marker line.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc3#n711

I was just beginning to think I actually had the format right, thanks
for the link

> Will any enumeration values become more helpful here?

Yes that's clearer, done locally, it'll be in the v2

> Please improve the size determination (or explanation).

That should be 2 bytes, thanks. It doesn't really need to be kzalloc()
then if the whole thing is set, the same goes for the other calls to
kzalloc().
I'll change those to kmalloc() unless there's a reason not to.

> I guess that you would not like to preserve code which was commented out.

I did mean to leave that there for the v1 only to ask if it was
worthwhile leaving, but I forgot to ask about it.
There's a comment ~16 lines back saying to use that exit point for any
failures after that point. It was a reminder while things were moving
around a lot, but I can drop it now if it's not worth keeping.

Thanks for the review

Stuart