linux-kernel - Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if vm_area_alloc_pages() with high order fallback to order 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240816091232.fsliktqgza5o5x6t@oppo.com>
Date: Fri, 16 Aug 2024 17:12:32 +0800
From: Hailong Liu <hailong.liu@...o.com>
To: Andrew Morton <akpm@...ux-foundation.org>
CC: Uladzislau Rezki <urezki@...il.com>, Michal Hocko <mhocko@...e.com>,
	"Barry Song" <21cnbao@...il.com>, Christoph Hellwig <hch@...radead.org>,
	"Vlastimil Babka" <vbabka@...e.cz>, Tangquan Zheng <zhengtangquan@...o.com>,
	<stable@...r.kernel.org>, Baoquan He <bhe@...hat.com>, Matthew Wilcox
	<willy@...radead.org>, <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH v1] mm/vmalloc: fix page mapping if
 vm_area_alloc_pages() with high order fallback to order 0

On Thu, 15. Aug 22:07, Andrew Morton wrote:
> On Fri, 9 Aug 2024 11:41:42 +0200 Uladzislau Rezki <urezki@...il.com> wrote:
>
> > > > Acked-by: Barry Song <baohua@...nel.org>
> > > >
> > > > because we already have a fallback here:
> > > >
> > > > void *__vmalloc_node_range_noprof :
> > > >
> > > > fail:
> > > >         if (shift > PAGE_SHIFT) {
> > > >                 shift = PAGE_SHIFT;
> > > >                 align = real_align;
> > > >                 size = real_size;
> > > >                 goto again;
> > > >         }
> > >
> > > This really deserves a comment because this is not really clear at all.
> > > The code is also fragile and it would benefit from some re-org.
> > >
> > > Thanks for the fix.
> > >
> > > Acked-by: Michal Hocko <mhocko@...e.com>
> > >
> > I agree. This is only clear for people who know the code. A "fallback"
> > to order-0 should be commented.
>
> It's been a week.  Could someone please propose a fixup patch to add
> this comment?

Hi Andrew:

Do you mean that I need to send a v2 patch with the the comments included?

--
Brs,
hailong.