linux-kernel - Re: [PATCH] kunit/overflow: Fix UB in overflow_allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64ab3938-9c0a-483e-9094-64baa1524d4a@gmail.com>
Date: Fri, 16 Aug 2024 02:22:23 +0100
From: Ivan Orlov <ivan.orlov0322@...il.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: kees@...nel.org, davidgow@...gle.com, kunit-dev@...glegroups.com,
 linux-kernel@...r.kernel.org, erhard_f@...lbox.org
Subject: Re: [PATCH] kunit/overflow: Fix UB in overflow_allocation_test

On 8/16/24 00:01, Andrew Morton wrote:
> On Thu, 15 Aug 2024 01:04:31 +0100 Ivan Orlov <ivan.orlov0322@...il.com> wrote:
> 
>> The 'device_name' array doesn't exist out of the
>> 'overflow_allocation_test' function scope. However, it is being used as
>> a driver name when calling 'kunit_driver_create' from
>> 'kunit_device_register'. It produces the kernel panic with KASAN
>> enabled.
>>
>> Since this variable is used in one place only, remove it and pass the
>> device name into kunit_device_register directly as an ascii string.
> 
> Fixes: ca90800a91ba ("test_overflow: Add memory allocation overflow tests")
> Cc: <stable@...r.kernel.org>
> 
> yes?
> 

Ah, yes, sorry, I should've specified the fixes tag in the patch :(

> 
> I'll grab it now, but perhaps Kees will handle this.
> 

Thanks!

-- 
Kind regards,
Ivan Orlov