linux-kernel - Re: linux-next: build failure after merge of the mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240816112920.55d293bf@oak>
Date: Fri, 16 Aug 2024 11:29:39 +1000
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Uros Bizjak <ubizjak@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, Linux Next Mailing List
 <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the mm tree

Hi Uros,

On Thu, 15 Aug 2024 09:42:51 +0200 Uros Bizjak <ubizjak@...il.com> wrote:
>
> > Caused by commit
> >
> >   8e53757638ec ("err.h: add ERR_PTR_PCPU(), PTR_ERR_PCPU() and IS_ERR_PCPU() functions")
> >
> > Does include/linux/err.h really need to include asm/percpu.h?  __percpu is
> > defined in compiler_types.h which is included in every c code compile.  
> 
> Currently it is not needed, but with the proposed patch [1]
> 
> [1] https://lore.kernel.org/lkml/20240812115945.484051-4-ubizjak@gmail.com/
> 
> that repurposes __percpu to also include percpu named address
> qualifier, it will be needed, because per_cpu_qual will be defined in
> include/asm-generic/percpu.h.

How about putting these new functions in a new header file
(err_percpu.h?) and including that where needed?  Are there going to be
many places that need these new functions?

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped