linux-kernel - Re: wifi: mwifiex: duplicate static structs used in driver instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172380168290.1353179.16302095751530116958.kvalo@kernel.org>
Date: Fri, 16 Aug 2024 09:48:04 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Sascha Hauer <s.hauer@...gutronix.de>
Cc: Brian Norris <briannorris@...omium.org>,
 Francesco Dolcini <francesco@...cini.it>,
 Yogesh Ashok Powar <yogeshp@...vell.com>, Bing Zhao <bzhao@...vell.com>,
 "John W. Linville" <linville@...driver.com>,
 Amitkumar Karwar <akarwar@...vell.com>, Avinash Patil <patila@...vell.com>,
 Kiran Divekar <dkiran@...vell.com>, linux-wireless@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...gutronix.de, stable@...r.kernel.org,
 Sascha Hauer <s.hauer@...gutronix.de>
Subject: Re: wifi: mwifiex: duplicate static structs used in driver instances

Sascha Hauer <s.hauer@...gutronix.de> wrote:

> mwifiex_band_2ghz and mwifiex_band_5ghz are statically allocated, but
> used and modified in driver instances. Duplicate them before using
> them in driver instances so that different driver instances do not
> influence each other.
> 
> This was observed on a board which has one PCIe and one SDIO mwifiex
> adapter. It blew up in mwifiex_setup_ht_caps(). This was called with
> the statically allocated struct which is modified in this function.
> 
> Cc: stable@...r.kernel.org
> Fixes: d6bffe8bb520 ("mwifiex: support for creation of AP interface")
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> Reviewed-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> Acked-by: Brian Norris <briannorris@...omium.org>

Patch applied to wireless.git, thanks.

27ec3c57fcad wifi: mwifiex: duplicate static structs used in driver instances

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240809-mwifiex-duplicate-static-structs-v1-1-6837b903b1a4@pengutronix.de/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches