linux-kernel - Re: [PATCH v1 3/5] gpio: rockchip: Set input direction in irq_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Me6XHGsmoRLBK3rb90=v7j9ChABMZjkVn4j5WQdzVv96A@mail.gmail.com>
Date: Fri, 16 Aug 2024 11:49:21 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Ye Zhang <ye.zhang@...k-chips.com>
Cc: linus.walleij@...aro.org, heiko@...ech.de, linux-gpio@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, tao.huang@...k-chips.com, 
	finley.xiao@...k-chips.com, tim.chen@...k-chips.com, 
	elaine.zhang@...k-chips.com
Subject: Re: [PATCH v1 3/5] gpio: rockchip: Set input direction in irq_request_resources

On Thu, Aug 15, 2024 at 9:17 AM Ye Zhang <ye.zhang@...k-chips.com> wrote:
>
> Set input direction to avoid FLAG_IS_OUT in gpiochip_lock_as_irq
>

That I can tell from the code. The commit message should say *why*
you're doing something.

Bart

> Signed-off-by: Ye Zhang <ye.zhang@...k-chips.com>
> ---
>  drivers/gpio/gpio-rockchip.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
> index b2f26a16b1f6..8949324ed816 100644
> --- a/drivers/gpio/gpio-rockchip.c
> +++ b/drivers/gpio/gpio-rockchip.c
> @@ -475,6 +475,8 @@ static int rockchip_irq_reqres(struct irq_data *d)
>         struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d);
>         struct rockchip_pin_bank *bank = gc->private;
>
> +       rockchip_gpio_direction_input(&bank->gpio_chip, d->hwirq);
> +
>         return gpiochip_reqres_irq(&bank->gpio_chip, d->hwirq);
>  }
>
> --
> 2.34.1
>