linux-kernel - Re: [PATCH v3] docs: Fix grammar and phrasing errors in reporting-issues.rst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f0e080d3-1ca4-409e-a038-657f0105b41a@leemhuis.info>
Date: Fri, 16 Aug 2024 11:58:07 +0200
From: Thorsten Leemhuis <linux@...mhuis.info>
To: SurajSonawane2415 <surajsonawane0215@...il.com>
Cc: corbet@....net, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] docs: Fix grammar and phrasing errors in
 reporting-issues.rst

On 16.08.24 11:36, SurajSonawane2415 wrote:
> Fix grammatical errors and improve phrasing in the `reporting-issues.rst`
> documentation file. These changes enhance readability and ensure the
> accuracy of the instructions provided.
>
> Signed-off-by: SurajSonawane2415 <surajsonawane0215@...il.com>
> ---
> V2 -> V3: Re-added the fix for the line: "That's why you might be need to uninstall the".
> V1 -> V2: emoved the unwanted change to the line: "try search terms like".

Thx, description sounds good. Final verdict ist up to Jonathan. And
changelog is great as well (apart from the typo in "removed", but
things happen, so no worries :-D )

Sadly there is one more thing where I apparently was unclear earlier: 
> @@ -472,7 +472,7 @@ before proceeding.
>  Note, you might not be aware that your system is using one of these solutions:
>  they often get set up silently when you install Nvidia's proprietary graphics
>  driver, VirtualBox, or other software that requires a some support from a
> -module not part of the Linux kernel. That why your might need to uninstall the
> +module not part of the Linux kernel. That's why you might be need to uninstall the
>  packages with such software to get rid of any 3rd party kernel module.

That last "the" makes the line too long, so it needs to move to the next
line. The diff thus should look like this in the end:

-module not part of the Linux kernel. That why your might need to uninstall the
+module not part of the Linux kernel. That's why you might be need to uninstall
+the packages with such software to get rid of any 3rd party kernel module.

But wait a moment: that additional "be" looks wrong to me. If you agree,
remove it and resend, then everything will be fine afaics. Sorry, I
should have noticed that earlier.

Ciao, Thorsten