[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zr8p96jwMHepFeq7@J2N7QTR9R3>
Date: Fri, 16 Aug 2024 11:29:11 +0100
From: Mark Rutland <mark.rutland@....com>
To: Robin Murphy <robin.murphy@....com>
Cc: will@...nel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, ilkka@...amperecomputing.com
Subject: Re: [PATCH 6/8] perf/arm-cmn: Refactor DTC PMU register access
On Fri, Aug 09, 2024 at 08:15:45PM +0100, Robin Murphy wrote:
> Annoyingly, we're soon going to have to cope with PMU registers moving
> about. This will mostly be straightforward, except for the hard-coding
> of CMN_PMU_OFFSET for the DTC PMU registers. As a first step, refactor
> those accessors to allow for encapsulating a variable offset without
> making a big mess all over.
>
> Signed-off-by: Robin Murphy <robin.murphy@....com>
> ---
> drivers/perf/arm-cmn.c | 64 ++++++++++++++++++++++++------------------
> 1 file changed, 36 insertions(+), 28 deletions(-)
Aside from a minoe comment below this looks fine to me.
> struct arm_cmn_dtc {
> void __iomem *base;
> + void __iomem *pmu_base;
> int irq;
> - int irq_friend;
> + s8 irq_friend;
Unrelated change?
AFAICT there's no reason for 'irq_friend' to change from 'int' to 's8',
and nothing in the commit message explains it.
Otherwise this all looks fine to me.
Mark.
Powered by blists - more mailing lists