[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5a3dd916-19a3-7c61-e19d-f257907ae47d@huaweicloud.com>
Date: Sat, 17 Aug 2024 15:16:33 +0800
From: Zhang Yi <yi.zhang@...weicloud.com>
To: Matthew Wilcox <willy@...radead.org>
Cc: linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-kernel@...r.kernel.org, djwong@...nel.org, hch@...radead.org,
brauner@...nel.org, david@...morbit.com, jack@...e.cz, yi.zhang@...wei.com,
chengzhihao1@...wei.com, yukuai3@...wei.com
Subject: Re: [PATCH v2 5/6] iomap: don't mark blocks uptodate after partial
zeroing
On 2024/8/17 12:48, Matthew Wilcox wrote:
> On Mon, Aug 12, 2024 at 08:11:58PM +0800, Zhang Yi wrote:
>> +++ b/fs/iomap/buffered-io.c
>> @@ -744,8 +744,8 @@ static int __iomap_write_begin(const struct iomap_iter *iter, loff_t pos,
>> poff, plen, srcmap);
>> if (status)
>> return status;
>> + iomap_set_range_uptodate(folio, poff, plen);
>> }
>> - iomap_set_range_uptodate(folio, poff, plen);
>> } while ((block_start += plen) < block_end);
>
> Um, what I meant was to just delete the iomap_set_range_uptodate()
> call in __iomap_write_begin() altogether. We'll call it soon enough in
> __iomap_write_end().
>
Yeah! Looks reasonable to me.
Thanks,
Yi.
Powered by blists - more mailing lists