linux-kernel - Re: [PATCH] iio: adc: ad7173: fix GPIO device info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240817112037.68cb99c2@jic23-huawei>
Date: Sat, 17 Aug 2024 11:20:37 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Dumitru Ceclan <mitrutzceclan@...il.com>
Cc: dlechner@...libre.com, dumitru.ceclan@...log.com0,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, Dumitru Ceclan
 <dumitru.ceclan@...log.com>
Subject: Re: [PATCH] iio: adc: ad7173: fix GPIO device info

On Fri,  9 Aug 2024 16:49:08 +0300
Dumitru Ceclan <mitrutzceclan@...il.com> wrote:

> Models AD4114/5/6 have .higher_gpio_bits = true. This is not correct as
> the only models that have the GPIO bits to a higher position are AD4111/2.
> 
> Fix by removing the higher_gpio_bits = true from the AD4114/5/6 models.
> 
> Fixes: 13d12e3ad12d ("iio: adc: ad7173: Add support for AD411x devices")
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@...log.com>
Applied and marked for stable.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/ad7173.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index 9544bf7142ad..b77e2beb502a 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -302,7 +302,6 @@ static const struct ad7173_device_info ad4114_device_info = {
>  	.num_configs = 8,
>  	.num_voltage_in = 16,
>  	.num_gpios = 4,
> -	.higher_gpio_bits = true,
>  	.has_vincom_input = true,
>  	.has_temp = true,
>  	.has_input_buf = true,
> @@ -320,7 +319,6 @@ static const struct ad7173_device_info ad4115_device_info = {
>  	.num_configs = 8,
>  	.num_voltage_in = 16,
>  	.num_gpios = 4,
> -	.higher_gpio_bits = true,
>  	.has_vincom_input = true,
>  	.has_temp = true,
>  	.has_input_buf = true,
> @@ -338,7 +336,6 @@ static const struct ad7173_device_info ad4116_device_info = {
>  	.num_configs = 8,
>  	.num_voltage_in = 16,
>  	.num_gpios = 4,
> -	.higher_gpio_bits = true,
>  	.has_vincom_input = true,
>  	.has_temp = true,
>  	.has_input_buf = true,