linux-kernel - RE: [PATCH v2 1/2] dt-bindings: iio: dac: add docs for ad8460

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SJ0PR03MB6224DC1CDD88776698BAB33691822@SJ0PR03MB6224.namprd03.prod.outlook.com>
Date: Sat, 17 Aug 2024 11:19:58 +0000
From: "Tinaco, Mariel" <Mariel.Tinaco@...log.com>
To: Jonathan Cameron <jic23@...nel.org>
CC: "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Lars-Peter
 Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        Conor Dooley <conor+dt@...nel.org>,
        Marcelo Schmitt
	<marcelo.schmitt1@...il.com>,
        Dimitri Fedrau <dima.fedrau@...il.com>,
        David
 Lechner <dlechner@...libre.com>,
        Nuno Sá
	<noname.nuno@...il.com>
Subject: RE: [PATCH v2 1/2] dt-bindings: iio: dac: add docs for ad8460



> -----Original Message-----
> From: Jonathan Cameron <jic23@...nel.org>
> Sent: Saturday, August 3, 2024 6:06 PM
> To: Tinaco, Mariel <Mariel.Tinaco@...log.com>
> Cc: linux-iio@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; Lars-Peter Clausen <lars@...afoo.de>; Rob Herring
> <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Hennerich,
> Michael <Michael.Hennerich@...log.com>; Conor Dooley
> <conor+dt@...nel.org>; Marcelo Schmitt <marcelo.schmitt1@...il.com>;
> Dimitri Fedrau <dima.fedrau@...il.com>; David Lechner
> <dlechner@...libre.com>; Nuno Sá <noname.nuno@...il.com>
> Subject: Re: [PATCH v2 1/2] dt-bindings: iio: dac: add docs for ad8460
> 
> [External]
> 
> On Tue, 30 Jul 2024 11:05:08 +0800
> Mariel Tinaco <Mariel.Tinaco@...log.com> wrote:
> 
> > This adds the bindings documentation for the 14-bit High Voltage, High
> > Current, Waveform Generator Digital-to-Analog converter.
> >
> A few additions to Krzysztof's much more detailed review.
> 
> Wrap patch descriptions to 75 chars. not sub 55.
> 
> > Signed-off-by: Mariel Tinaco <Mariel.Tinaco@...log.com>
> > +
> > +  adi,rset-ohms:
> 
> Please rename this as rset sounds like reset to me.  Not sure what a good name
> is however!
> 
> 
> > +    description: Specify value of external resistor connected to FS_ADJ pin
> > +      to establish internal HVDAC's reference current I_REF
> > +    default: 2000
> > +    minimum: 2000
> > +    maximum: 20000
> > +


Replaced the name

  adi,external-resistor-ohms:
    description: Specify value of external resistor connected to FS_ADJ pin
      to establish internal HVDAC's reference current I_REF
    default: 2000
    minimum: 2000
    maximum: 20000

Regards,
Mariel