linux-kernel - Re: [PATCH] iio: proximity: hx9023s: Fix error code in hx9023s_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240817135209.0682b74e@jic23-huawei>
Date: Sat, 17 Aug 2024 13:52:09 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Yasin Lee <yasin.lee.x@...il.com>, Lars-Peter Clausen <lars@...afoo.de>,
 Nuno Sa <nuno.sa@...log.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] iio: proximity: hx9023s: Fix error code in
 hx9023s_property_get()

On Mon, 12 Aug 2024 09:43:05 +0300
Dan Carpenter <dan.carpenter@...aro.org> wrote:

> If we're returning because "reg >= HX9023S_CH_NUM" then set the error code
> to -ENIVAL instead of success.
> 
> Fixes: 60df548277b7 ("iio: proximity: Add driver support for TYHX's HX9023S capacitive proximity sensor")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
Hi Dan,

Applied,

Thanks,

Jonathan

> ---
>  drivers/iio/proximity/hx9023s.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/proximity/hx9023s.c b/drivers/iio/proximity/hx9023s.c
> index fe14a62a1342..8b9f84400e00 100644
> --- a/drivers/iio/proximity/hx9023s.c
> +++ b/drivers/iio/proximity/hx9023s.c
> @@ -598,7 +598,8 @@ static int hx9023s_property_get(struct hx9023s_data *data)
>  	device_for_each_child_node_scoped(dev, child) {
>  		ret = fwnode_property_read_u32(child, "reg", &reg);
>  		if (ret || reg >= HX9023S_CH_NUM)
> -			return dev_err_probe(dev, ret, "Failed to read reg\n");
> +			return dev_err_probe(dev, ret < 0 ? ret : -EINVAL,
> +					     "Failed to read reg\n");
>  		__set_bit(reg, &data->chan_in_use);
>  
>  		ret = fwnode_property_read_u32(child, "single-channel", &temp);