linux-kernel - Re: [PATCH v4 3/3] PCI: rockchip: Refactor rockchip_pcie_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANAwSgSqUoO+=GdFRnW5MOvbA+-sHPe2oEpzvd6O9KpzJ1tdmA@mail.gmail.com>
Date: Sat, 17 Aug 2024 18:52:55 +0530
From: Anand Moon <linux.amoon@...il.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: Shawn Lin <shawn.lin@...k-chips.com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Krzysztof Wilczyński <kw@...ux.com>, 
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Heiko Stuebner <heiko@...ech.de>, 
	linux-pci@...r.kernel.org, linux-rockchip@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/3] PCI: rockchip: Refactor rockchip_pcie_disable_clocks
 function signature

Hi Manivannan

Thanks for your review comments.

On Thu, 15 Aug 2024 at 21:55, Manivannan Sadhasivam
<manivannan.sadhasivam@...aro.org> wrote:
>
> On Tue, Jun 25, 2024 at 04:10:34PM +0530, Anand Moon wrote:
> > Updated rockchip_pcie_disable_clocks function to accept
> > a struct rockchip pointer instead of a void pointer.
> >
>
> Please use imperative tone in all patch descriptions.
>

Ok, I will try to improve.

> s/Updated/Update
>
> > Signed-off-by: Anand Moon <linux.amoon@...il.com>
>
> With above,
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>
Ok
> - Mani

Thanks

-Anand