linux-kernel - Re: [PATCH 3/6] kbuild: rust: re-run Kconfig if the version text changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72n60=dKdsu0X3CWLaCkEhnAHMuwRZZpwhiJMGkt0aGyUw@mail.gmail.com>
Date: Sat, 17 Aug 2024 15:28:16 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Nicolas Schier <nicolas@...sle.eu>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Wedson Almeida Filho <wedsonaf@...il.com>, Masahiro Yamada <masahiroy@...nel.org>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...sung.com>, 
	Alice Ryhl <aliceryhl@...gle.com>, rust-for-linux@...r.kernel.org, 
	Nathan Chancellor <nathan@...nel.org>, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH 3/6] kbuild: rust: re-run Kconfig if the version text changes

On Sat, Aug 17, 2024 at 2:58 PM Nicolas Schier <nicolas@...sle.eu> wrote:
>
> If you send a v2, mind you consider reformatting so that this comment
> block stays <= 80 chars?

Sure.

> Do we already support rust in external kernel modules?  In top-level

If you mean out-of-tree modules, then yeah, they should generally work
(at least I test the build with a trivial one regularly, but perhaps
it is missing something), although they are not the highest priority.

> Makefile's oot-kmod 'prepare' target we check that the compiler
> (version) is the same as when the kernel itself was built.  If rust
> modules are supported, adding a similar check might be helpful.

That is a good point, I will take a look.

> Reviewed-by: Nicolas Schier <nicolas@...sle.eu>

Thanks!

Cheers,
Miguel