linux-kernel - Re: [PATCH] scsi: ufs: ufshcd-pltfrm: Signedness bug in ufshcd_parse_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1jzggot2f.fsf@ca-mkp.ca.oracle.com>
Date: Fri, 16 Aug 2024 21:07:42 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Rob Herring <robh@...nel.org>,
        "James E.J. Bottomley"
 <James.Bottomley@...senpartnership.com>,
        "Martin K. Petersen"
 <martin.petersen@...cle.com>,
        Manivannan Sadhasivam
 <manivannan.sadhasivam@...aro.org>,
        Bart Van Assche <bvanassche@....org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Brian Masney
 <bmasney@...hat.com>,
        Nitin Rawat <quic_nitirawa@...cinc.com>,
        Can Guo
 <quic_cang@...cinc.com>, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] scsi: ufs: ufshcd-pltfrm: Signedness bug in
 ufshcd_parse_clock_info()


Dan,

> The "sz" variable needs to be a signed type for the error handling to
> work as intended. Fortunately, there is some sanity checking on "sz"
> on the next line, so negative values would be caught and it doesn't
> really affect runtime.

Applied to 6.12/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering