linux-kernel - Re: [PATCH] m68k/mac: Revise PowerBook 500 series model name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9da54e36-682f-aba1-a5fb-4e41665b9873@linux-m68k.org>
Date: Sun, 18 Aug 2024 09:56:50 +1000 (AEST)
From: Finn Thain <fthain@...ux-m68k.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
cc: Joshua Thompson <funaho@...ai.org>, Stan Johnson <userm57@...oo.com>, 
    Michael Schmitz <schmitzmic@...il.com>, linux-m68k@...ts.linux-m68k.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k/mac: Revise PowerBook 500 series model name


On Sat, 17 Aug 2024, Geert Uytterhoeven wrote:

> On Mon, Aug 12, 2024 at 8:56 AM Finn Thain <fthain@...ux-m68k.org> wrote:
> > The PowerBook 520, 540 and 550 all have macintosh_config->ident == 72
> > because that's their gestalt ID in MacOS. Hence, Linux describes them all
> > as "Powerbook 520". Change that to "Powerbook 500 series", which is more
> > accurate.
> >
> > Cc: Joshua Thompson <funaho@...ai.org>
> > Cc: Stan Johnson <userm57@...oo.com>
> > Reported-by: Stan Johnson <userm57@...oo.com>
> > Signed-off-by: Finn Thain <fthain@...ux-m68k.org>
> 
> Thanks for your patch!
> 
> > --- a/arch/m68k/mac/config.c
> > +++ b/arch/m68k/mac/config.c
> > @@ -677,7 +677,7 @@ static struct mac_model mac_data_table[] = {
> >                 .floppy_type    = MAC_FLOPPY_OLD, /* SWIM 2 */
> >         }, {
> >                 .ident          = MAC_MODEL_PB520,
> > -               .name           = "PowerBook 520",
> > +               .name           = "PowerBook 500 series",
> >                 .adb_type       = MAC_ADB_PB2,
> >                 .via_type       = MAC_VIA_QUADRA,
> >                 .scsi_type      = MAC_SCSI_OLD,
> 
> This is a user-visible change, through /proc/hardware.
> Do you know if any userspace relies on the old string value?
> 

I did a search on sources.debian.org and didn't find anything. OTOH, a 
search for "powerbook" doesn't actually return Michael's packages that 
used to be available for powerbooks...

Anyway, I agree that /proc/hardware should remain stable, so please 
disregard this patch.