[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <71d341e0-d988-41a9-bf61-c691537749fc@roeck-us.net>
Date: Fri, 16 Aug 2024 17:03:16 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Rob Herring <robh@...nel.org>, Frank Li <Frank.Li@....com>
Cc: Jean Delvare <jdelvare@...e.com>, Krzysztof Kozlowski
<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
"open list:HARDWARE MONITORING" <linux-hwmon@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: hwmon/regulator: Convert ltc2978.txt to
yaml
On 8/16/24 14:55, Rob Herring wrote:
> On Wed, Aug 14, 2024 at 02:17:26PM -0400, Frank Li wrote:
>> Convert binding doc ltc2978.txt to yaml format.
>> Additional change:
>> - add i2c node.
>> - basic it is regulator according to example, move it under regulator.
>>
>> Fix below warning:
>> arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: /soc/i2c@...0000/i2c-mux@...i2c@...egulator@5c:
>> failed to match any schema with compatible: ['lltc,ltc3882']
>>
>> Signed-off-by: Frank Li <Frank.Li@....com>
>> ---
>> .../devicetree/bindings/hwmon/ltc2978.txt | 62 ------------
>> .../bindings/regulator/lltc,ltc2972.yaml | 94 +++++++++++++++++++
>> 2 files changed, 94 insertions(+), 62 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/hwmon/ltc2978.txt
>> create mode 100644 Documentation/devicetree/bindings/regulator/lltc,ltc2972.yaml
>
> I'm on the fence whether to move this...
>
I don't really understand the rationale behind the move nor the rationale behind
the rename, but then I don't really care or mind as long as no one claims that
the _driver_ should be moved because the devicetree bindings moved.
Note that "basic it is a regulator" is a bit stretching. The driver's regulator
functionality must be enabled with a separate configuration option; the driver
works perfectly fine as hardware monitoring driver if SENSORS_LTC2978_REGULATOR=n.
Guenter
Powered by blists - more mailing lists