linux-kernel - Re: [PATCH] Initialize symbol 'entity' in sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZsFvQFnG/LEkzT0V@DUT025-TGLU.fm.intel.com>
Date: Sun, 18 Aug 2024 03:49:20 +0000
From: Matthew Brost <matthew.brost@...el.com>
To: Dipendra Khadka <kdipendra88@...il.com>
CC: <ltuikov89@...il.com>, <maarten.lankhorst@...ux.intel.com>,
	<mripard@...nel.org>, <tzimmermann@...e.de>, <airlied@...il.com>,
	<daniel@...ll.ch>, <dri-devel@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Initialize symbol 'entity' in sched_main.c

On Sat, Aug 17, 2024 at 04:20:24PM +0000, Dipendra Khadka wrote:
> smatch reported following error:
> 
> '''
> staging/drivers/gpu/drm/scheduler/sched_main.c:1063 drm_sched_select_entity() error: uninitialized symbol 'entity'.
> '''
> 
> The symbol entity is initialized.
> 

Looks like false postive, no opposed merging it but since
'sched->num_rqs' must be greater than zero it entity should always be
set unless I'm missing something.

Matt

> Signed-off-by: Dipendra Khadka <kdipendra88@...il.com>
> ---
>  drivers/gpu/drm/scheduler/sched_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 7e90c9f95611..dcfd4d0f7c6e 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -1047,7 +1047,7 @@ void drm_sched_wakeup(struct drm_gpu_scheduler *sched,
>  static struct drm_sched_entity *
>  drm_sched_select_entity(struct drm_gpu_scheduler *sched)
>  {
> -	struct drm_sched_entity *entity;
> +	struct drm_sched_entity *entity = NULL;
>  	int i;
>  
>  	/* Start with the highest priority.
> -- 
> 2.43.0
>