linux-kernel - Re: [PATCH 1/2] dt-bindings: display: renesas,du: narrow interrupts and resets per variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240818174137.GC29465@pendragon.ideasonboard.com>
Date: Sun, 18 Aug 2024 20:41:37 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Magnus Damm <magnus.damm@...il.com>,
	dri-devel@...ts.freedesktop.org, linux-renesas-soc@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: renesas,du: narrow interrupts
 and resets per variants

Hi Krzysztof,

Thank you for the patch.

On Sun, Aug 18, 2024 at 07:30:02PM +0200, Krzysztof Kozlowski wrote:
> Each variable-length property like interrupts or resets must have fixed
> constraints on number of items for given variant in binding.  The
> clauses in "if:then:" block should define both limits: upper and lower.

I thought that, when only one of minItems or maxItems was specified, the
other automatically defaulted to the same value. I'm pretty sure I
recall Rob asking me to drop one of the two in some bindings. Has the
rule changes ? Is it documented somewhere ?

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  .../bindings/display/renesas,du.yaml          | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml
> index c5b9e6812bce..147842b6465a 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.yaml
> +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
> @@ -173,6 +173,7 @@ allOf:
>              - pattern: '^dclkin\.[01]$'
>  
>          interrupts:
> +          minItems: 2
>            maxItems: 2
>  
>          resets:
> @@ -228,6 +229,7 @@ allOf:
>              - pattern: '^dclkin\.[01]$'
>  
>          interrupts:
> +          minItems: 2
>            maxItems: 2
>  
>          resets:
> @@ -281,6 +283,7 @@ allOf:
>              - pattern: '^dclkin\.[01]$'
>  
>          interrupts:
> +          minItems: 2
>            maxItems: 2
>  
>          resets:
> @@ -335,6 +338,7 @@ allOf:
>              - pattern: '^dclkin\.[01]$'
>  
>          interrupts:
> +          minItems: 2
>            maxItems: 2
>  
>          resets:
> @@ -396,6 +400,7 @@ allOf:
>              - pattern: '^dclkin\.[012]$'
>  
>          interrupts:
> +          minItems: 3
>            maxItems: 3
>  
>          resets:
> @@ -460,9 +465,11 @@ allOf:
>              - pattern: '^dclkin\.[0123]$'
>  
>          interrupts:
> +          minItems: 4
>            maxItems: 4
>  
>          resets:
> +          minItems: 2
>            maxItems: 2
>  
>          reset-names:
> @@ -489,9 +496,11 @@ allOf:
>  
>          renesas,cmms:
>            minItems: 4
> +          maxItems: 4
>  
>          renesas,vsps:
>            minItems: 4
> +          maxItems: 4
>  
>        required:
>          - clock-names
> @@ -531,9 +540,11 @@ allOf:
>              - pattern: '^dclkin\.[012]$'
>  
>          interrupts:
> +          minItems: 3
>            maxItems: 3
>  
>          resets:
> +          minItems: 2
>            maxItems: 2
>  
>          reset-names:
> @@ -558,9 +569,11 @@ allOf:
>  
>          renesas,cmms:
>            minItems: 3
> +          maxItems: 3
>  
>          renesas,vsps:
>            minItems: 3
> +          maxItems: 3
>  
>        required:
>          - clock-names
> @@ -600,9 +613,11 @@ allOf:
>              - pattern: '^dclkin\.[013]$'
>  
>          interrupts:
> +          minItems: 3
>            maxItems: 3
>  
>          resets:
> +          minItems: 2
>            maxItems: 2
>  
>          reset-names:
> @@ -627,9 +642,11 @@ allOf:
>  
>          renesas,cmms:
>            minItems: 3
> +          maxItems: 3
>  
>          renesas,vsps:
>            minItems: 3
> +          maxItems: 3
>  
>        required:
>          - clock-names
> @@ -684,6 +701,7 @@ allOf:
>  
>          renesas,vsps:
>            minItems: 1
> +          maxItems: 1
>  
>        required:
>          - clock-names
> @@ -719,6 +737,7 @@ allOf:
>              - pattern: '^dclkin\.[01]$'
>  
>          interrupts:
> +          minItems: 2
>            maxItems: 2
>  
>          resets:
> @@ -746,9 +765,11 @@ allOf:
>  
>          renesas,cmms:
>            minItems: 2
> +          maxItems: 2
>  
>          renesas,vsps:
>            minItems: 2
> +          maxItems: 2
>  
>        required:
>          - clock-names
> @@ -799,6 +820,7 @@ allOf:
>  
>          renesas,vsps:
>            minItems: 2
> +          maxItems: 2
>  
>        required:
>          - clock-names

-- 
Regards,

Laurent Pinchart