linux-kernel - Re: [PATCH v2] init/Kconfig: Only block on RANDSTRUCT for RUST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72mSa4_=DSFUMkq129ByQFkPk_5Y0BdY6J0Skj7Npj99-w@mail.gmail.com>
Date: Sun, 18 Aug 2024 23:32:44 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Neal Gompa <neal@...pa.dev>
Cc: rust-for-linux@...r.kernel.org, asahi@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>, 
	Hector Martin <marcan@...can.st>, Janne Grunau <j@...nau.net>, Asahi Lina <lina@...hilina.net>
Subject: Re: [PATCH v2] init/Kconfig: Only block on RANDSTRUCT for RUST

On Wed, Jul 31, 2024 at 2:57 PM Neal Gompa <neal@...pa.dev> wrote:
>
> When enabling Rust in the kernel, we only need to block on the
> RANDSTRUCT feature and GCC plugin. The rest of the GCC plugins
> are reasonably safe to enable.
>
> Signed-off-by: Neal Gompa <neal@...pa.dev>

Applied to `rust-next` -- thanks!

    [ Originally (years ago) we only had this restriction, but we ended up
      restricting also the rest of the GCC plugins 1) to be on the safe side,
      2) since compiler plugin support could be going away in the kernel and
      3) since mixed builds are best effort so far; so I asked Neal about
      his experience enabling the other plugins -- Neal says:

        When I originally wrote this patch two years ago to get things
        working, Fedora used all the GCC plugins, so I was trying to get GCC +
        Rust to work while minimizing the delta on build differences. This was
        the combination that worked. We've been carrying this patch in the
        Asahi tree for a year now. And while Fedora does not currently have
        GCC plugins enabled because it caused issues with some third-party
        modules (I think it was the NVIDIA driver, but I'm not sure), it was
        around long enough for me to know with some confidence that it was
        fine this way.

      - Miguel ]

Cheers,
Migul