linux-kernel - Re: [PATCH v2] kbuild: rust: auto generate rust helper exports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72k81VrS+3Skh7gfYzkcxTsGscUJOhroV4MXH-LZgroZFg@mail.gmail.com>
Date: Mon, 19 Aug 2024 01:40:44 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Boqun Feng <boqun.feng@...il.com>
Cc: Gary Guo <gary@...yguo.net>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Wedson Almeida Filho <wedsonaf@...il.com>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...sung.com>, 
	Alice Ryhl <aliceryhl@...gle.com>, Dirk Behme <dirk.behme@...bosch.com>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kbuild: rust: auto generate rust helper exports

On Sun, Aug 18, 2024 at 2:49 AM Boqun Feng <boqun.feng@...il.com> wrote:
>
> Reviewed-by: Boqun Feng <boqun.feng@...il.com>
>
> This also passed my test script (x86, arm64 and riscv build and kunit
> tests).

Hmm... I think you either tested another one, or you manually fixed
the dependency (`$(obj)/helpers/helpers.o`).

Or am I confused?

> Miguel, I think it makes more sense if we take this one and the
> helpers.c split one as early as possible, given they are treewide
> changes ;-)

Agreed, we should take it soon. I have rebased it on top of
`rust-next` and fixed the dependency.

Please take a look:

    https://github.com/Rust-for-Linux/linux/commit/0d6e3e8d3677ee7b5cccf9bc002e18f140c02a4e

I will put it in after we confirm we are not confused :) (and after we
get a linux-next round or two for what is currently there).

Extra `Tested-by`s would be nice!

Cheers,
Miguel