linux-kernel - Re: [PATCH v11 01/14] EDAC: Add support for EDAC device feature's control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202408181416.PD0B8fMf-lkp@intel.com>
Date: Sun, 18 Aug 2024 15:11:13 +0800
From: kernel test robot <lkp@...el.com>
To: shiju.jose@...wei.com, linux-edac@...r.kernel.org,
	linux-cxl@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, bp@...en8.de,
	tony.luck@...el.com, rafael@...nel.org, lenb@...nel.org,
	mchehab@...nel.org, dan.j.williams@...el.com, dave@...olabs.net,
	jonathan.cameron@...wei.com, dave.jiang@...el.com,
	alison.schofield@...el.com, vishal.l.verma@...el.com,
	ira.weiny@...el.com, david@...hat.com, Vilas.Sridharan@....com,
	leo.duran@....com, Yazen.Ghannam@....com, rientjes@...gle.com,
	jiaqiyan@...gle.com, Jon.Grimm@....com, dave.hansen@...ux.intel.com,
	naoya.horiguchi@....com, james.morse@....com, jthoughton@...gle.com,
	somasundaram.a@....com, erdemaktas@...gle.com
Subject: Re: [PATCH v11 01/14] EDAC: Add support for EDAC device feature's
 control

Hi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on ras/edac-for-next]
[also build test WARNING on rafael-pm/linux-next rafael-pm/bleeding-edge cxl/next linus/master cxl/pending v6.11-rc3 next-20240816]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/shiju-jose-huawei-com/EDAC-Add-support-for-EDAC-device-feature-s-control/20240817-004442
base:   https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git edac-for-next
patch link:    https://lore.kernel.org/r/20240816164238.1902-2-shiju.jose%40huawei.com
patch subject: [PATCH v11 01/14] EDAC: Add support for EDAC device feature's control
config: i386-buildonly-randconfig-003-20240818 (https://download.01.org/0day-ci/archive/20240818/202408181416.PD0B8fMf-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240818/202408181416.PD0B8fMf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408181416.PD0B8fMf-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/edac/edac_device.c:608: warning: Function parameter or struct member 'ras_feat' not described in 'edac_dev_feat_init'
>> drivers/edac/edac_device.c:608: warning: expecting prototype for edac_dev_feature_init(). Prototype was for edac_dev_feat_init() instead


vim +608 drivers/edac/edac_device.c

   593	
   594	/**
   595	 * edac_dev_feature_init - Init a ras feature
   596	 * @parent: client device.
   597	 * @dev_data: pointer to struct edac_dev_data.
   598	 * @feat: pointer to struct edac_dev_feature.
   599	 * @attr_groups: pointer to attribute group's container.
   600	 *
   601	 * Returns number of scrub feature's attribute groups on success,
   602	 * error otherwise.
   603	 */
   604	static int edac_dev_feat_init(struct device *parent,
   605				      struct edac_dev_data *dev_data,
   606				      const struct edac_dev_feature *ras_feat,
   607				      const struct attribute_group **attr_groups)
 > 608	{
   609		int num;
   610	
   611		switch (ras_feat->feat) {
   612		case RAS_FEAT_SCRUB:
   613			dev_data->scrub_ops = ras_feat->scrub_ops;
   614			dev_data->private = ras_feat->scrub_ctx;
   615			return 1;
   616		case RAS_FEAT_ECS:
   617			num = ras_feat->ecs_info.num_media_frus;
   618			dev_data->ecs_ops = ras_feat->ecs_ops;
   619			dev_data->private = ras_feat->ecs_ctx;
   620			return num;
   621		case RAS_FEAT_PPR:
   622			dev_data->ppr_ops = ras_feat->ppr_ops;
   623			dev_data->private = ras_feat->ppr_ctx;
   624			return 1;
   625		default:
   626			return -EINVAL;
   627		}
   628	}
   629	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki