linux-kernel - Re: [PATCH v2] kbuild: rust: auto generate rust helper exports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kGyuhthMQA7bLaVduUS08AuVf-805_e0w9_vwBp0JcGA@mail.gmail.com>
Date: Mon, 19 Aug 2024 02:17:08 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Gary Guo <gary@...yguo.net>
Cc: Boqun Feng <boqun.feng@...il.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Wedson Almeida Filho <wedsonaf@...il.com>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...sung.com>, 
	Alice Ryhl <aliceryhl@...gle.com>, Dirk Behme <dirk.behme@...bosch.com>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kbuild: rust: auto generate rust helper exports

On Mon, Aug 19, 2024 at 1:56 AM Gary Guo <gary@...yguo.net> wrote:
>
> It's the mistake on my patch. I noticed the exact issue while I was
> trying to rebase my helper-lto patch :)
>
> I believe that reason that it builds fine for me previously and for
> Boqun was that we didn't delete the helpers.o generated prior to
> applying the helper split patch, and we know that kbuild is not
> hermetic.

Yeah, probably it was that -- as you say, it would require a stale
`rust/helpers.o` from a build before Andreas' patch (and not just
before this patch).

> Your rebase and the fix is identical to the one I got locally, and I
> can confirm that it compiles fine for a clean build.

Thanks a lot for taking a look!

Cheers,
Miguel