linux-kernel - Re: [PATCH -next 6/8] drm/panel: khadas-ts050: Make ts050_panel_data and ts050v2_panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd53b240-0db6-4d27-85d6-e2004086fd29@linaro.org>
Date: Mon, 19 Aug 2024 17:34:32 +0200
From: neil.armstrong@...aro.org
To: Jinjie Ruan <ruanjinjie@...wei.com>, quic_jesszhan@...cinc.com,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
 airlied@...il.com, daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 6/8] drm/panel: khadas-ts050: Make ts050_panel_data
 and ts050v2_panel_data static

On 19/08/2024 14:00, Jinjie Ruan wrote:
> The sparse tool complains as follows:
> 
> drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32: warning:
> 	symbol 'ts050_panel_data' was not declared. Should it be static?
> 
> drivers/gpu/drm/panel/panel-khadas-ts050.c:625:32: warning:
> 	symbol 'ts050v2_panel_data' was not declared. Should it be static?
> 
> These symbols are not used outside panel-khadas-ts050.c, so marks them static.
> 
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
>   drivers/gpu/drm/panel/panel-khadas-ts050.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-khadas-ts050.c b/drivers/gpu/drm/panel/panel-khadas-ts050.c
> index 14932cb3defc..0e5e8e57bd1e 100644
> --- a/drivers/gpu/drm/panel/panel-khadas-ts050.c
> +++ b/drivers/gpu/drm/panel/panel-khadas-ts050.c
> @@ -617,12 +617,12 @@ static const struct khadas_ts050_panel_cmd ts050_init_code[] = {
>   	{0xd4, {0x04}, 0x01}, /* RGBMIPICTRL: VSYNC front porch = 4 */
>   };
>   
> -struct khadas_ts050_panel_data ts050_panel_data = {
> +static struct khadas_ts050_panel_data ts050_panel_data = {
>   	.init_code = (struct khadas_ts050_panel_cmd *)ts050_init_code,
>   	.len = ARRAY_SIZE(ts050_init_code)
>   };
>   
> -struct khadas_ts050_panel_data ts050v2_panel_data = {
> +static struct khadas_ts050_panel_data ts050v2_panel_data = {
>   	.init_code = (struct khadas_ts050_panel_cmd *)ts050v2_init_code,
>   	.len = ARRAY_SIZE(ts050v2_init_code)
>   };

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>