linux-kernel - Re: [PATCH v2] mm: add lazyfree folio to lru tail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuCfpFGsWO+zyerjSwB7b0hyh8HYy4dsebe94Tqg0KqzVA6tg@mail.gmail.com>
Date: Mon, 19 Aug 2024 09:11:50 -0700
From: Suren Baghdasaryan <surenb@...gle.com>
To: David Hildenbrand <david@...hat.com>
Cc: gaoxu <gaoxu2@...or.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	"linux-mm@...ck.org" <linux-mm@...ck.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Shaohua Li <shli@...com>, 
	yipengxiang <yipengxiang@...or.com>, fengbaopeng <fengbaopeng@...or.com>, 
	Kalesh Singh <kaleshsingh@...gle.com>, Yu Zhao <yuzhao@...gle.com>
Subject: Re: [PATCH v2] mm: add lazyfree folio to lru tail

On Fri, Aug 16, 2024 at 3:21 AM David Hildenbrand <david@...hat.com> wrote:
>
> On 16.08.24 12:19, David Hildenbrand wrote:
> > On 16.08.24 09:48, gaoxu wrote:
> >> Replace lruvec_add_folio with lruvec_add_folio_tail in the lru_lazyfree_fn:
> >> 1. The lazy-free folio is added to the LRU_INACTIVE_FILE list. If it's
> >>      moved to the LRU tail, it allows for faster release lazy-free folio and
> >>      reduces the impact on file refault.
> >> 2. When mglru is enabled, the lazy-free folio is reclaimabled and should be
> >>      added using lru_gen_add_folio(lruvec, folio, true) instead of
> >>      lru_gen_add_folio(lruvec, folio, false) for adding to gen.
> >>
> >> With the change in place, workingset_refault_file is reduced by 33% in the
> >> continuous startup testing of the applications in the Android system.

Was this improvement recorded with MGLRU enabled or disabled?
CC'ing Yu Zhao as well.

> >>
> >
> > The patch subject does not match what you do in the patch -- at all.
> >
> > "mm/swap: use lruvec_add_folio_tail() in lru_lazyfree()" ?
>
> Ah, sorry, I read it too fast. Yours does make sense :)
>
> (mm/swap might make sense, though)
>
> --
> Cheers,
>
> David / dhildenb
>