linux-kernel - Re: [PATCH] drm/panel: mantix-mlaf057we51: transition to mipi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f868cbd6-11f2-4fb1-beae-639aaa1bb0d1@linaro.org>
Date: Mon, 19 Aug 2024 18:38:09 +0200
From: neil.armstrong@...aro.org
To: Doug Anderson <dianders@...omium.org>
Cc: Tejas Vipin <tejasvipin76@...il.com>, agx@...xcpu.org, kernel@...i.sm,
 quic_jesszhan@...cinc.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: mantix-mlaf057we51: transition to mipi_dsi
 wrapped functions

On 19/08/2024 18:14, Doug Anderson wrote:
> Hi,
> 
> On Mon, Aug 19, 2024 at 8:36 AM <neil.armstrong@...aro.org> wrote:
>>
>> Hi,
>>
>> On 18/08/2024 09:23, Tejas Vipin wrote:
>>> Changes the mantix-mlaf057we51 panel to use multi style functions for
>>> improved error handling.
>>>
>>> Signed-off-by: Tejas Vipin <tejasvipin76@...il.com>
>>> ---
>>>    .../gpu/drm/panel/panel-mantix-mlaf057we51.c  | 79 +++++++------------
>>>    1 file changed, 27 insertions(+), 52 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
>>> index ea4a6bf6d35b..4db852ffb0f6 100644
>>> --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
>>> +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
>>> @@ -23,7 +23,7 @@
>>>
>>>    /* Manufacturer specific Commands send via DSI */
>>>    #define MANTIX_CMD_OTP_STOP_RELOAD_MIPI 0x41
>>> -#define MANTIX_CMD_INT_CANCEL           0x4C
>>> +#define MANTIX_CMD_INT_CANCEL           0x4c
>>
>> Please move cleanups to separate patches
> 
> LOL, in a previous patch series I had the upper-to-lowercase in a
> separate patch and someone yelled at me to do the opposite and squash
> it together [1]. It doesn't really matter too much to me, but given
> the previous feedback I've just been suggesting that Tejas squash it
> together with his conversions. I'm OK either way, though.

Yeah it heavily depends on the rename, but I guess here it's fine to be applied as-is!

Neil

> 
> [1] https://lore.kernel.org/r/CAA8EJpo4WzMPNjpnkHt-_GJe2TAF_i_G+eTaJrGipMEzppc3rQ@mail.gmail.com
> 
> -Doug