linux-kernel - [PATCH 5.15.y V2] block: use "unsigned long" for blk_validate_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240819002324.2284362-1-david.hunter.linux@gmail.com>
Date: Sun, 18 Aug 2024 20:23:24 -0400
From: David Hunter <david.hunter.linux@...il.com>
To: stable@...r.kernel.org
Cc: axboe@...nel.dk,
	linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	david.hunter.linux@...il.com,
	javier.carrasco.cruz@...il.com,
	shuah@...nel.org,
	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	Christoph Hellwig <hch@....de>
Subject: [PATCH 5.15.y V2] block: use "unsigned long" for blk_validate_block_size().

From: Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>

[ Upstream commit 37ae5a0f5287a52cf51242e76ccf198d02ffe495]

Since lo_simple_ioctl(LOOP_SET_BLOCK_SIZE) and ioctl(NBD_SET_BLKSIZE) pass
user-controlled "unsigned long arg" to blk_validate_block_size(),
"unsigned long" should be used for validation.

Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Reviewed-by: Christoph Hellwig <hch@....de>
Link: https://lore.kernel.org/r/9ecbf057-4375-c2db-ab53-e4cc0dff953d@i-love.sakura.ne.jp
Signed-off-by: Jens Axboe <axboe@...nel.dk>
(cherry picked from commit 37ae5a0f5287a52cf51242e76ccf198d02ffe495)
Signed-off-by: David Hunter <david.hunter.linux@...il.com>
---
V1 --> V2
	- put upstream commit after subject 
	- put the original Author
	- Added a few people I needed to CC
---
 include/linux/blkdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 905844172cfd..c6d57814988d 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -235,7 +235,7 @@ struct request {
 	void *end_io_data;
 };
 
-static inline int blk_validate_block_size(unsigned int bsize)
+static inline int blk_validate_block_size(unsigned long bsize)
 {
 	if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize))
 		return -EINVAL;
-- 
2.43.0