[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOMZO5C_uvmuf-+QGH4E2X=Jei81a--N5wC83V-URPkXj-q7hw@mail.gmail.com>
Date: Mon, 19 Aug 2024 14:23:55 -0300
From: Fabio Estevam <festevam@...il.com>
To: Frank Li <Frank.Li@....com>, Adam Ford <aford173@...il.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
Gregor Herburger <gregor.herburger@...tq-group.com>,
Alexander Stein <alexander.stein@...tq-group.com>, devicetree@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux@...tq-group.com
Subject: Re: [PATCH v2 12/12] arm64: dts: imx8mm-beacon-kit: add DVDD-supply
and DOVDD-supply
Adding Adam.
On Mon, Aug 19, 2024 at 2:03 PM Frank Li <Frank.Li@....com> wrote:
>
> According to binding doc, DVDD-supply and DOVDD-supply is required
> properties. Add these to fix below warning:
> arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb: camera@10: 'DVDD-supply' is a required proper
>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> .../boot/dts/freescale/imx8mm-beacon-baseboard.dtsi | 16 ++++++++++++++++
> .../boot/dts/freescale/imx8mn-beacon-baseboard.dtsi | 16 ++++++++++++++++
> 2 files changed, 32 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
> index 6086dae2e5fbe..ea1d5b9c6bae0 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi
> @@ -56,6 +56,20 @@ pcie0_refclk_gated: pcie0-refclk-gated {
> enable-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>;
> };
>
> + reg_1v5: regulator-1v5 {
> + compatible = "regulator-fixed";
> + regulator-name = "1V5";
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <1500000>;
> + };
> +
> + reg_1v8: regulator-1v8 {
> + compatible = "regulator-fixed";
> + regulator-name = "1V8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> reg_audio: regulator-audio {
> compatible = "regulator-fixed";
> regulator-name = "3v3_aud";
> @@ -187,6 +201,8 @@ camera@10 {
> assigned-clock-parents = <&clk IMX8MM_CLK_24M>;
> assigned-clock-rates = <24000000>;
> AVDD-supply = <®_camera>; /* 2.8v */
> + DVDD-supply = <®_1v5>;
> + DOVDD-supply = <®_1v8>;
> powerdown-gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>;
> reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi
> index 20018ee2c803e..77d14ea459e57 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-beacon-baseboard.dtsi
> @@ -40,6 +40,20 @@ led-3 {
> };
> };
>
> + reg_1v5: regulator-1v5 {
> + compatible = "regulator-fixed";
> + regulator-name = "1V5";
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <1500000>;
> + };
> +
> + reg_1v8: regulator-1v8 {
> + compatible = "regulator-fixed";
> + regulator-name = "1V8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> reg_audio: regulator-audio {
> compatible = "regulator-fixed";
> regulator-name = "3v3_aud";
> @@ -158,6 +172,8 @@ camera@10 {
> assigned-clock-parents = <&clk IMX8MN_CLK_24M>;
> assigned-clock-rates = <24000000>;
> AVDD-supply = <®_camera>; /* 2.8v */
> + DVDD-supply = <®_1v5>;
> + DOVDD-supply = <®_1v8>;
> powerdown-gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>;
> reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
>
>
> --
> 2.34.1
>
Powered by blists - more mailing lists