linux-kernel - Re: [PATCH] drm/panel: ili9341: Add comments for ILI9341 register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZsOFoP+NR/pGNC5M@embed-PC.myguest.virtualbox.org>
Date: Mon, 19 Aug 2024 23:19:20 +0530
From: Abhishek Tamboli <abhishektamboli9@...il.com>
To: neil.armstrong@...aro.org
Cc: maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
	tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch,
	quic_jesszhan@...cinc.com, dri-devel@...ts.freedesktop.org,
	skhan@...uxfoundation.org, rbmarliere@...il.com,
	linux-kernel-mentees@...ts.linuxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: ili9341: Add comments for ILI9341 register

Hi, Neil
Thanks for the feedback.

On Mon, Aug 19, 2024 at 05:41:07PM +0200, neil.armstrong@...aro.org wrote:
> On 12/08/2024 19:10, Abhishek Tamboli wrote:
> > TODO : Add missing comments for ILI9341 register definition.
> 
> Please rephrase the commit message, and explain why in a proper english sentence.
Sure
> Neil
> 
> > 
> > Signed-off-by: Abhishek Tamboli <abhishektamboli9@...il.com>
> > ---
> >   drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 14 +++++++-------
> >   1 file changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> > index 775d5d5e828c..cba6a6952568 100644
> > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> > @@ -121,19 +121,19 @@ struct ili9341_config {
> >   	const struct drm_display_mode mode;
> >   	/* ca: TODO: need comments for this register */
> >   	u8 ca[ILI9341_CA_LEN];
> > -	/* power_b: TODO: need comments for this register */
> > +	/* power_b: Power control B (CFh) */
> >   	u8 power_b[ILI9341_POWER_B_LEN];
> > -	/* power_seq: TODO: need comments for this register */
> > +	/* pdtcaower_seq: Power on sequence control (EDh) */
> >   	u8 power_seq[ILI9341_POWER_SEQ_LEN];
> > -	/* dtca: TODO: need comments for this register */
> > +	/* dtca: Driver timing control A (E8h) */
> >   	u8 dtca[ILI9341_DTCA_LEN];
> > -	/* dtcb: TODO: need comments for this register */
> > +	/* dtcb: Driver timing control B (EAh) */
> >   	u8 dtcb[ILI9341_DTCB_LEN];
> > -	/* power_a: TODO: need comments for this register */
> > +	/* power_a: Power control A (CBh) */
> >   	u8 power_a[ILI9341_POWER_A_LEN];
> >   	/* frc: Frame Rate Control (In Normal Mode/Full Colors) (B1h) */
> >   	u8 frc[ILI9341_FRC_LEN];
> > -	/* prc: TODO: need comments for this register */
> > +	/* prc: Pump ratio control (F7h) */
> >   	u8 prc;
> >   	/* dfc_1: B6h DISCTRL (Display Function Control) */
> >   	u8 dfc_1[ILI9341_DFC_1_LEN];
> > @@ -147,7 +147,7 @@ struct ili9341_config {
> >   	u8 vcom_2;
> >   	/* address_mode: Memory Access Control (36h) */
> >   	u8 address_mode;
> > -	/* g3amma_en: TODO: need comments for this register */
> > +	/* g3amma_en: Enable 3G (F2h) */
> >   	u8 g3amma_en;
> >   	/* rgb_interface: RGB Interface Signal Control (B0h) */
> >   	u8 rgb_interface;
> > --
> > 2.34.1
> > 
Regards,
Abhishek