linux-kernel - Re: [PATCH -next] zonefs: add support for FS_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55ca393e-e2e9-45ef-8eb0-050d79c92987@kernel.org>
Date: Mon, 19 Aug 2024 13:08:04 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Liao Chen <liaochen4@...wei.com>, linux-fsdevel@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, naohiro.aota@....com, jth@...nel.org
Subject: Re: [PATCH -next] zonefs: add support for FS_IOC_GETFSSYSFSPATH

On 8/9/24 10:36, Liao Chen wrote:
> FS_IOC_GETFSSYSFSPATH ioctl expects sysfs sub-path of a filesystem, the
> format can be "$FSTYP/$SYSFS_IDENTIFIER" under /sys/fs, it can helps to
> standardizes exporting sysfs datas across filesystems.
> 
> This patch wires up FS_IOC_GETFSSYSFSPATH for zonefs, it will output
> "zonefs/<dev>".
> 
> Signed-off-by: Liao Chen <liaochen4@...wei.com>
> ---
>  fs/zonefs/super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
> index faf1eb87895d..e180daa39578 100644
> --- a/fs/zonefs/super.c
> +++ b/fs/zonefs/super.c
> @@ -1262,6 +1262,7 @@ static int zonefs_fill_super(struct super_block *sb, struct fs_context *fc)
>  	sb->s_maxbytes = 0;
>  	sb->s_op = &zonefs_sops;
>  	sb->s_time_gran	= 1;
> +	super_set_sysfs_name_id(sb);

Can you resend the patch with this call moved to the beginning of
zonefs_sysfs_register() in fs/zonefs/sysfs.c ?
Thanks.

>  
>  	/*
>  	 * The block size is set to the device zone write granularity to ensure

-- 
Damien Le Moal
Western Digital Research