linux-kernel - Re: [PATCH] kselftest: timers: Fix const correctness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANDhNCqoHvvTUk7tmR7u+WPKQV1B7Eztf3TWYDpCQXgLXQijsQ@mail.gmail.com>
Date: Mon, 19 Aug 2024 11:34:52 -0700
From: John Stultz <jstultz@...gle.com>
To: Piotr Zalewski <pZ010001011111@...ton.me>
Cc: anna-maria@...utronix.de, frederic@...nel.org, tglx@...utronix.de, 
	sboyd@...nel.org, shuah@...nel.org, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] kselftest: timers: Fix const correctness

On Mon, Aug 19, 2024 at 10:58 AM Piotr Zalewski
<pZ010001011111@...ton.me> wrote:
>
> Make timespec pointers, pointers to const in checklist function. As a
> consequence, make list parameter in checklist function pointer to const
> as well. Const-correctness increases readability.
>
> Improvement was found by running cppcheck tool on the patched file as
> follows:
> ```
> cppcheck --enable=all \
>         tools/testing/selftests/timers/threadtest.c \
>         --suppress=missingIncludeSystem \
>         --suppress=unusedFunction
> ```
>
> Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>
> Signed-off-by: Piotr Zalewski <pZ010001011111@...ton.me>

Acked-by: John Stultz <jstultz@...gle.com>

thanks
-john